Fix Life360 Pet Profile artifact icon#922
Merged
Merged
Conversation
Change artifact_icon from 'github' (octocat) to 'smile', a valid Feather icon better suited to a pet profile. Feather has no paw/animal icon.
abrignoni
force-pushed
the
fix-life360-petprofile-icon
branch
from
8ac06a8 to
a13a5a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Life360 Pet Profile artifact (
L360petprofile.py) usedartifact_icon: 'github'(an octocat), which doesn't reflect a pet.Changed it to
smile, a valid Feather icon better suited to a pet profile. Feather has no paw/dog/cat icon, so this is an approximation from the available set (validates againstfeather_icon_names, so noalert-trianglefallback).One-line, icon-only change. Lint 10.00/10.